V3 remove deprecated bigtable admin#15908
V3 remove deprecated bigtable admin#15908scotthart wants to merge 11 commits intogoogleapis:prepare-for-v3.0.0from
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request advances the V3 migration by systematically removing outdated Bigtable admin client interfaces. It ensures that the codebase, particularly the integration tests, aligns with the new, more consistent client libraries for Bigtable administration, and provides clear guidance for users transitioning to these updated APIs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the codebase from deprecated bigtable::AdminClient and related classes to the new bigtable_admin::BigtableTableAdminClient and bigtable_admin::BigtableInstanceAdminClient APIs. The changes involve updating includes, member variable types, and method calls in integration tests to reflect the new API structure. Additionally, several old files and integration tests have been commented out using #if 0 directives, indicating their deprecation and removal. The v3-migration-guide.md has been updated to provide clear instructions for users migrating to the new API, which is a valuable addition for maintainability and user experience.
doc/v3-migration-guide.md
Outdated
| <details> | ||
| <summary>Removed <code>bigtable::AdminClient</code></summary> | ||
|
|
||
| The `bigtable::AdminClient` class has been removed in and replaced with |
There was a problem hiding this comment.
The phrasing "removed in and replaced with" sounds a bit awkward. Consider rephrasing for better clarity.
| The `bigtable::AdminClient` class has been removed in and replaced with | |
| The `bigtable::AdminClient` class has been removed and replaced with |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15908 +/- ##
======================================================
- Coverage 92.87% 92.81% -0.06%
======================================================
Files 2343 2334 -9
Lines 216141 214699 -1442
======================================================
- Hits 200734 199267 -1467
- Misses 15407 15432 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
force-pushed
the
v3_remove_deprecated_bigtable_admin
branch
3 times, most recently
from
48b2d8a to
2214a2e
Compare
scotthart
force-pushed
the
v3_remove_deprecated_bigtable_admin
branch
from
2214a2e to
16e8be8
Compare
1 participant
This change is